Remove passing view options as a function #2486
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2229
Essentially Marionette.Views allow you to pass in options as a function like:
For one thing it is inconsistent with option handling on anything that is not a view: https://github.com/marionettejs/backbone.marionette/blob/master/src/object.js#L7
And another thing.. it is really pretty pointless and probably promotes bad patterns.
Also it was a largely broken "feature" for most of its existence.