2707 - Flag metal #2709
2707 - Flag metal #2709
Conversation
jasonLaster
force-pushed
the
flag-metal
branch
2 times, most recently
from
9927aa1
to
7aea85d
Compare
|
|
||
| <script> | ||
| window.Marionette = Backbone.Marionette = {}; | ||
| window.slice = Array.prototype.slice; | ||
| </script> | ||
|
|
||
| <script src="src/features.js"></script> |
There was a problem hiding this comment.
features needs to be defined before metal.js
jasonLaster
force-pushed
the
flag-metal
branch
2 times, most recently
from
f030167
to
c7cee98
Compare
|
lol.. Now it's jscs. @jasonLaster don't use |
|
Lol |
jasonLaster
force-pushed
the
flag-metal
branch
2 times, most recently
from
af1be88
to
ca86537
Compare
Updates + Adds class flag + Enables class flag in tests + Adds a features.md file
jasonLaster
force-pushed
the
flag-metal
branch
from
ca86537
to
66dcbff
Compare
| @@ -0,0 +1,19 @@ | |||
| # Features | |||
|
|
|||
| Marionette Features are opt-in functionality. That you can enable by setting `Marionette.Features` in your app. | |||
There was a problem hiding this comment.
- Marionette.Features
+ Marionette.FEATURES
There was a problem hiding this comment.
ping @jasonLaster I think this is the last tweak here.
|
Oh boy, so we decided to go ahead and overwrite Backbone classes? I realize there is probably no perfect solution, but just curious what the final reasoning was. |
|
Well I think we don't know exactly what's what with the metal stuff, but rather than revert it's all just flagged. ( #2637 ) |
|
Gotcha. Yeah, given an experimental-feature flag, might as well experiment :) |
|
@jasonLaster one quick fix on this PR and it can get merged. |
|
My hanks Paul |
|
Lol autocorrect. Will get to it soon |
|
Manually merged. |
|
Thanks! |
Fixes #2707
We're not going to support class and classify out of the gate so adding some flags