Make sure $el contains only the el

[paulfalgout]

Alternative solution to #3421

This is a WIP and needs tests, but I think doing this check once on _ensureElement is better than within attachHtml And it makes this.$el more consistent and matches what happens in the region constructor

This still needs a test

[coveralls]

Coverage remained the same at 100.0% when pulling 0fa0480 on paulfalgout:bugfix/region-select-one into 1962fbb on marionettejs:next.

[JSteunou]

Calling getEl twice eh... Kinda ironic. Wouldnt be better if the 1st call always return only one element. I dont see where we use multiple elements from getEl

[paulfalgout]

I can't find a way in which returning a single element from region.getEl isn't far more complicated.
FWIW all I did was move a getEl from attach which is called on every show up into the show which will only be called the first time. We could maybe just call this.Dom.getEl directly.. That might be better here.

[coveralls]

Coverage remained the same at 100.0% when pulling f930ef0 on paulfalgout:bugfix/region-select-one into 1962fbb on marionettejs:next.

[scott-w]

Would jQuery .first() not work to resolve that issue? https://api.jquery.com/first/

[paulfalgout]

We shouldn't require jQuery here at all.

[scott-w]

I meant inside the DOM API somewhere.

[paulfalgout]

I would consider that a breaking change

[paulfalgout]

I suppose it is still an experimental API. still though.. I'm not sure what the concern is about this change. it is 100% the same code that is currently ready for v3.4.2 it's just that the Dom.getEl is now called once for a region instead of every show.

[scott-w]

I'm fine with it I just wanted to play devil's advocate 😈

[JSteunou]

Same... The solution just seems clunky even if right, I cannot stop thinking it must be a more elegant way

[paulfalgout]

I think the more elegant way comes with #3417 and removing any sort of getEl from regions altogether.

[JSteunou]

What about here ? We could return the 1st element directly.

[JSteunou]

Which conflict with #3425

Ok no more ideas :D

👍

[scott-w]

I'm happy with this, we should add a test, however.

[paulfalgout]

updated with a test

[coveralls]

Coverage remained the same at 100.0% when pulling 1e5fe04 on paulfalgout:bugfix/region-select-one into 4af7db8 on marionettejs:next.