Make MarionetteError a private util #3495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blikblum
approved these changes
Oct 13, 2017
paulfalgout
force-pushed
the
refactor/error
branch
from
2fed105
to
7c7ad62
Compare
Part of the marionettejs#3393 work was removing exporting of `MarionetteError`. This allows for making the class more specific to internal use and can help us enforce a more consistent error API. Along with this I changed the error names to "${ ClassName }Error" if possible to make it more valuable in determining the origin. Most of the error names were restating the error message and were never reused. Similarly I added a url for every error. Errors will fallback to generic docs if nothing is set.
paulfalgout
force-pushed
the
refactor/error
branch
from
7c7ad62
to
0601631
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the #3393 work was removing exporting of
MarionetteError.This allows for making the class more specific to internal use and can help us enforce a more consistent error API.
Along with this I changed the error names to "${ ClassName }Error" if possible to make it more valuable in determining the origin. Most of the error names were restating the error message and were never reused.
Similarly I added a url for every error. Errors will fallback to generic docs if nothing is set.