Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reorganize and refactor common triggerMethod, normalizeMethods, and m… #3549

Merged
merged 1 commit into from
Nov 20, 2017
Merged

reorganize and refactor common triggerMethod, normalizeMethods, and m… #3549

merged 1 commit into from
Nov 20, 2017

Conversation

wesmangum
Copy link
Contributor

…ergeOptions unit tests

Proposed changes

  • Reorganize tests to match order of codebase
  • Import dependencies to move away from using global ones
  • Use let in favor of this in beforeEach

Link to the issue: #3248

This pr is a small part of the work to refactor the whole unit tests directory. Merging this issue should keep #3248 open

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d234123 on wesmangum:tests/common/mergeOptions-normalizeMethods-triggerMethod into 2b2bee3 on marionettejs:next.

@paulfalgout paulfalgout merged commit 4a465aa into marionettejs:next Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulfalgout paulfalgout paulfalgout approved these changes

@blikblum blikblum blikblum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wesmangum @coveralls @paulfalgout @blikblum