Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

once methods are broken #51

Closed
jamesplease opened this issue Jun 3, 2014 · 2 comments · Fixed by #52
Closed

once methods are broken #51

jamesplease opened this issue Jun 3, 2014 · 2 comments · Fixed by #52
Assignees
@jamesplease
Labels
bug

Comments

@jamesplease
Copy link
Member

The once methods should pass things off to the on methods, not the trigger methods.

This flew under the radar because there are no tests for this behavior. Code coverage would have helped here :(
@jamesplease jamesplease added the bug label Jun 3, 2014
@jamesplease jamesplease mentioned this issue Jun 3, 2014
Closed
jamesplease added a commit that referenced this issue Jun 3, 2014
@jamesplease
Once methods delegate to on.
63606dc 
Resolves #51.
@jamesplease jamesplease mentioned this issue Jun 3, 2014
Merged
@jamiebuilds
Copy link
Member

wow...

@jamesplease
Copy link
Member Author

rofl

jamesplease added a commit that referenced this issue Jun 5, 2014
@jamesplease
Once methods delegate to on.
dbb45da 
Resolves #51.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesplease jamesplease

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Once methods delegate to on. marionettejs/backbone.radio
2 participants
@jamiebuilds @jamesplease