Feature/272 es6 pkg module

[pglewis]

Fixes #272

• Gets rid of implicit global warnings in the Rollup build
• Updates Babel and Rollup related packages
• Generates a .esm.js module and map file

[blikblum]

It's failing due to webpack version.

As a side note, later, we should replace webpack by rollup

[pglewis]

I wonder if just rolling back babel-loader to 6.2.0 would be enough to iron it out. That one isn't involved in the build so I probably should have left it alone.

[scott-w]

I'm a fan and I love seeing work being done to keep the package up-to-date with the latest build tools.

I just have a question around artefacts as I'm a bit behind on how es6 package modules work.

[scott-w]

Does this file need to be checked into the source tree or is it automatically generated?

[pglewis]

Ah, yes, I should have added the module and source map to git

[pglewis]

It's wired into the build so would get generated with the rest of the files in build/ in the future.

I'm not sure what needs to be done, if anything for the NPM package to include the ES modules.

[blikblum]

The es build must be in the package distributed.

Commit in the repository is optional. Anyway if deciding to commit to repository, It should be done only just before a release.

[paulfalgout]

this line doesn't appear to be in use.

[pglewis]

Yeah, detritus. Yanked in 8f563e5

[paulfalgout]

@marionettejs/marionette-core if 2nd thumb'd squash and merge

[paulfalgout]

We need to make sure this has named exports

[blikblum]

I think it can be merged as is.

The addition of named exports can be added later since means a bigger change and needs some discussion.

Radio public API is basically Channel class, channel function , reset, tuneIn, tuneOut, log, debugLog

While in Marionette migrating everything to named exports and killing the default exports was straight, in Radio doing the same will be a big breaking change.

By far the most used API in channel function, used like:

import Radio from 'backbone.radio'

Radio.channel('yy').request('xx')

By migrating to named exports like it would need to be changed to

import {channel} from 'backbone.radio'

channel('yy').request('xx')

There's some issues:

• channel is not a good name for a function, looks more like a variable
• channel and Channel would be exported, adding confusion
• debugLog could not be override

So migrating to named exports is possible but will need some API design changes that at this time (just before releasing marionette v4) i don't think is doable.

I propose to merge this and open a new issue for named export