Refactor Tests

[jamiebuilds]

I started on some stuff and kinda went crazy.. I'll try my best to detail everything I did.

Changes:

• Move spec/radio.js tests into spec/channel.js (ref: Merge spec/radio.js into spec/channel.js #45)
• Reduce repetition in tests by taking advantage of beforeEach/afterEach and nested describes (ref: Reduce repetition in tests #30)
• Use deep equal where appropriate
• Don't use unnecessary spies
• Use better assertions
• Use _.clone(Object) instead of _.extend({}, Object)

The DEBUG mode tests were all different, so I flattened the describe/beforeEach blocks into just it blocks so it would read easier

this.reactStub        = this.sinon.stub(this.channel, 'react');
this.reactOnceStub    = this.sinon.stub(this.channel, 'reactOnce');
this.stopReactingStub = this.sinon.stub(this.channel, 'stopReacting');
this.commandStub      = this.sinon.stub(this.channel, 'command');
// instead:
this.channelStub = this.sinon.stub(this.channel);
// as long as you don't need to actually call anything on this.channel

this.callback = function() { return 'the thing'; };
this.callbackSpy = this.sinon.spy(this.callback);
// instead:
this.callbackStub = this.sinon.stub().returns('the thing');

// use these properly
this.sinon.spy(this.object, 'function_that_i_want_to_call_through');
this.sinon.stub(this.object, 'function_that_i_dont_want_to_call_through');

expect(this.channel._channelName).to.equal(this.channelName);
// instead:
expect(this.channel).to.have.property('_channelName', this.channelName);

this.channelName = this.channel._channelName;
this.channelKeys = _.keys(this.channel);
this.eventKeys   = _.keys(Backbone.Events);
this.requestKeys = _.keys(Backbone.Radio.Requests);
this.commandKeys = _.keys(Backbone.Radio.Commands);
this.eventIntersect   = _.intersection(this.eventKeys, this.channelKeys);
this.requestIntersect = _.intersection(this.requestKeys, this.channelKeys);
this.commandIntersect = _.intersection(this.commandKeys, this.channelKeys);
expect(this.eventIntersect.length).to.equal(this.eventKeys.length);
expect(this.requestIntersect.length).to.equal(this.requestKeys.length);
expect(this.commandIntersect.length).to.equal(this.commandKeys.length);
// instead:
expect(this.channel).to.contain(Backbone.Events);
expect(this.channel).to.contain(Backbone.Radio.Requests);
expect(this.channel).to.contain(Backbone.Radio.Commands);

expect(this.channelStub.listenTo).to.have.been.calledOnce;
expect(this.channelStub.listenTo).to.have.been.calledWithExactly('foo1', 'bar1');
// instead:
expect(this.channelStub.listenTo).to.have.been.calledOnce.and.calledWithExactly('foo1', 'bar1');

expect(function() { ... }).not.to.throw(Error);
// instead:
this.stopReacting = function() { ... };
expect(this.stopReacting).not.to.throw(Error);

You might just want to open the files side by side and go through them that way. The diff is gonna suck to go through

[jamiebuilds]

@jmeas I'm so sorry

[jamesplease]

Ha 👍 this is awesome. Thanks for doing this @thejameskyle :)

Reviewing now

[jamesplease]

this is beautiful 😢

[jamesplease]

👏

this is amazing @thejameskyle. Thanks again for doing this. I only had a few comments, then it's ready for merge I think.

[jamiebuilds]

@jmeas I'll let you respond to my comments and I'll fix them all at once.

[jamesplease]

I have no other comments, so feel free to update whenever you've got some time :)

[jamiebuilds]

@jmeas Okay, updated

[jamesplease]

Manually merged