Use $.find, not $.children, to parse nested inputs within a specific form
#110
Conversation
|
👍 Fantastic; great work @david-davidson |
Use `$.find`, not `$.children`, to parse nested inputs within a specific form
|
When is this going to be released in the master version? |
|
Ping - any chance of getting this into a release? |
|
yes we can cut a release today :) @happylinks @jwhitfieldseed do either of you want to help maintain this lib with us :) |
|
@samccone I am pretty short on open source time at the moment but I will help out where I can :) |
|
Sure, sounds fun. I'll try to help when needed :) |
|
Bump - can somebody please release this? If there's anything I can do to help, let me know. |
|
I build it myself and updated the version, not sure if I did it 100% correct though. Anybody care to check? happylinks@a525b2e |
|
@happylinks @jwhitfieldseed released as 0.6.1 |
|
Shouldn't you also run grunt build? Currently the lib/backbone.syphon.js in minor is still old. Or am I mistaken? |
|
yea I messed up 😢 sorry all fixed in 0.6.2 |
|
Jee, thanks a lot! :) |
|
thank you! |
Reopening against minor
This updates
getFormto rely on$.find, not$.children, when searching for inputs within a specific form (not a view). That's consistent with how it handles inputs within a view (View.$, which is the equivalent of$.find), and it lets Syphon pull data from inputs nested more than one level down, like<div><input></input></div>. Fixes #104 ./cc @rhubarbselleven
Marionette: 2.4.1 / Syphon: 0.6.0