adds the ability to ignore types by selector #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var identifier = extractor($(el)); | ||
|
|
||
| var foundInIgnored = _.include(config.ignoredTypes, type); | ||
| var foundInIgnored = _.find(config.ignoredTypes, function(ignoredTypeOrSelector) { | ||
| return (ignoredTypeOrSelector === myType) || $(el).is(ignoredTypeOrSelector); |
There was a problem hiding this comment.
Yeah I found that in the original PR
You advanced to level 2
Wooooo
rhubarbselleven
force-pushed
the
selectors-can-ignore-too
branch
from
cfa981a
to
f55d768
Compare
| }); | ||
|
|
||
| it('should not include fields excluded by selector', function() { | ||
| expect(this.result).not.to.have.ownProperty('b'); |
There was a problem hiding this comment.
oh i mean
expect(this.result).to.eql([....])
There was a problem hiding this comment.
Ah, gotcha.
Lightbulb 💡
rhubarbselleven
force-pushed
the
selectors-can-ignore-too
branch
from
f55d768
to
64ebfb8
Compare
|
Ugh, hold this. I just wrote a failing testcase for the deserialize side of things |
rhubarbselleven
force-pushed
the
selectors-can-ignore-too
branch
2 times, most recently
from
bad13b4
to
4493218
Compare
|
HA! Was due to a typo
|
rhubarbselleven
force-pushed
the
selectors-can-ignore-too
branch
from
4493218
to
de26ad9
Compare
|
Lgtm. Great work |
rhubarbselleven
added a commit
that referenced
this pull request
Mar 14, 2015
adds the ability to ignore types by selector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can add a selector to
ignoredTypeswhich will exclude the field from serialise / deserialise if it matches