Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with JavaScript on downloads pages #302

Closed
peterblazejewicz opened this issue Feb 24, 2015 · 5 comments
Closed

Fix issues with JavaScript on downloads pages #302

peterblazejewicz opened this issue Feb 24, 2015 · 5 comments
Labels
bug

Comments

@peterblazejewicz
Copy link
Member

image
@samccone
Copy link
Member

oh no

@samccone samccone added the bug label Feb 24, 2015
@samccone
Copy link
Member

I don't see those actually...

@peterblazejewicz
Copy link
Member Author

hm, now it's fine. Which 3rd party code gets injected into page? (SPOF behaviour)

@peterblazejewicz
Copy link
Member Author

Got this again. That's our code, there is no carousel on downloads page.
20150224233549

I'll fix this with upcoming PR which adds blocks to layouts - so we will be able to include per-page scripts (but here we could add safe-check)

@peterblazejewicz peterblazejewicz mentioned this issue Feb 24, 2015
Merged
@samccone
Copy link
Member

odd that mine did not blow up

peterblazejewicz added a commit that referenced this issue Feb 25, 2015
@peterblazejewicz
Merge pull request #306 from peterblazejewicz/fix/302
ea46d64 
Add safety check to code block. Fixes #302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peterblazejewicz @samccone