Optimize listen function #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use grep first to receive only the wanted lines - Flush the pending events to call output only once With multiple occurrences of pulseaudio-control started, I noticed that on quick changes (i.e. volume or iterating through the sinks), the cpu usage increased a lot for the action. pactl is quite noisy, and a single event can generate multiple matching lines. This commit reduces the calls to output to one per 100ms.
|
Awesome. I've roughly measured the performant effect and you can actually see it. When generating lots of events (mainly increasing or decreasing the volume rapidly), htop reports 8-9% CPU load with the previous implementation. Now it's always under 2%. Props for the idea! Merging once CI runs, thanks again. |
This was referenced Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With multiple occurrences of pulseaudio-control started, I noticed
that on quick changes (i.e. volume or iterating through the sinks),
the cpu usage increased a lot for the action.
pactl is quite noisy, and a single event can generate multiple
matching lines.
This commit reduces the calls to output to one per 100ms.