Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix argument parsing #66

Merged
merged 2 commits into from
Jun 29, 2022
Merged

Fix argument parsing #66

merged 2 commits into from
Jun 29, 2022

Conversation

marioortizmanero
Copy link
Owner

This should close #63

@Aerion
Copy link
Contributor

Aerion commented Jun 28, 2022

Thanks for the swift response.

The original command is now fixed, but it seems to have introduced a regression:

# No errors expected
$ ./pulseaudio-control.bash --osd --icons-volume "A"
Unrecognised action: A
# This works great though!
./pulseaudio-control.bash --osd output
64% Sink #89

@marioortizmanero
Copy link
Owner Author

Ah, whoops. Looks like shift modifies the function's arguments instead of the global arguments. Not the prettiest, but it should be fixed now.

@Aerion
Copy link
Contributor

Aerion commented Jun 29, 2022

Sweet, looks good!

@marioortizmanero marioortizmanero merged commit d3df2cb into master Jun 29, 2022
@marioortizmanero marioortizmanero deleted the fix-args branch June 29, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI flag followed by value removes the value
2 participants