Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --listen-timeout-secs #71

Merged
merged 2 commits into from
Jul 13, 2022
Merged

Add --listen-timeout-secs #71

merged 2 commits into from
Jul 13, 2022

Conversation

marioortizmanero
Copy link
Owner

Fixes #70. @thennothinghappened, please let me know if this solves your issue. You may be interested in this feature as well, @Aerion.

@marioortizmanero
Copy link
Owner Author

marioortizmanero commented Jul 5, 2022

Should we also modify the default value? Or is it good enough at 100 ms? I did change it on my own setup to 50 ms, but not sure what the default should be.

Going from 100 ms to 50 ms on my system increases the maximum load when spamming a lot from 1.9% to 2.6% (very roughly). The difference is somewhat noticeable visually. I would say it's good enough for my case, since for this test I spammed it as much as I could, which isn't a realistic use-case.

Shall we use 50 ms? Also, is the documentation for the new flag ok? Too many details?

@Aerion
Copy link
Contributor

Aerion commented Jul 10, 2022

Documentation looks good. Users probably expect quick responsiveness to the changes.
What do you think of changing it to 50ms, but adding a section in the README indicating what to do if the CPU usage is too high for the user?

@marioortizmanero
Copy link
Owner Author

Sounds good! I'll do that and release a new version.

@marioortizmanero
Copy link
Owner Author

I've just added a FAQ section, which I wanted to do for a long time anyway. That includes a question about CPU usage and insufficient latency.

@marioortizmanero marioortizmanero merged commit 889c005 into master Jul 13, 2022
@marioortizmanero marioortizmanero deleted the latency-flag branch July 13, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No longer updates every time volume changes
2 participants