Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More precise string values on *Json.type #21

Closed
mariosimao opened this issue Nov 6, 2021 · 0 comments · Fixed by #50
Closed

More precise string values on *Json.type #21

mariosimao opened this issue Nov 6, 2021 · 0 comments · Fixed by #50
Assignees
@mariosimao
Labels
enhancement New feature or request
Projects
Notion PHP SDK
Milestone
v0.3.0

Comments

@mariosimao
Copy link
Owner

Consider being more precise around string values that are constrained within a certain range. For example, this could be Block::TYPE_*

Originally posted by @Ocramius in #6 (comment)
@mariosimao mariosimao mentioned this issue Nov 6, 2021
Closed
@mariosimao mariosimao added the enhancement New feature or request label Nov 6, 2021
@mariosimao mariosimao added this to To do in Notion PHP SDK Nov 7, 2021
@mariosimao mariosimao moved this from To do to In progress in Notion PHP SDK Nov 22, 2021
@mariosimao mariosimao moved this from In progress to Reviewer approved in Notion PHP SDK Nov 22, 2021
@mariosimao mariosimao moved this from Reviewer approved to Done in Notion PHP SDK Nov 22, 2021
@mariosimao mariosimao self-assigned this Nov 22, 2021
@mariosimao mariosimao added this to the v0.3.0 milestone Nov 22, 2021
@mariosimao mariosimao linked a pull request Nov 22, 2021 that will close this issue
Use consts on Psalm Json types #50
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mariosimao mariosimao

Labels
enhancement New feature or request
Projects
No open projects
Notion PHP SDK
  
Done
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

Use consts on Psalm Json types mariosimao/notion-sdk-php
1 participant
@mariosimao