Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): query all pages #211

Merged
merged 1 commit into from
Apr 26, 2023
Merged

fix(search): query all pages #211

merged 1 commit into from
Apr 26, 2023

Conversation

mariosimao
Copy link
Owner

No description provided.

@mariosimao mariosimao linked an issue Apr 26, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #211 (3ddcc2a) into main (f5914f7) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##               main     #211   +/-   ##
=========================================
  Coverage     99.13%   99.13%           
  Complexity     1294     1294           
=========================================
  Files           158      158           
  Lines          4153     4153           
=========================================
  Hits           4117     4117           
  Misses           36       36           
Impacted Files Coverage Δ
src/Search/Client.php 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mariosimao mariosimao merged commit 37d98f3 into main Apr 26, 2023
@mariosimao mariosimao deleted the fix-210 branch April 26, 2023 22:42
@mariosimao mariosimao self-assigned this Apr 26, 2023
@rickyheijnen
Copy link

Thank you for the quick fix!

Just saying: I think you could have fixed it easier by just adding the JSON_FORCE_OBJECT flag to json_encode in \Notion\Search\Client.php . That also does the trick.

@mariosimao
Copy link
Owner Author

Thank you for the quick fix!

Just saying: I think you could have fixed it easier by just adding the JSON_FORCE_OBJECT flag to json_encode in \Notion\Search\Client.php . That also does the trick.

Indeed this would also solve the issue. I decided to use stdClass to make it explicit that it should be an empty object instead of an empty array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Search all pages with Query::all() is not working correctly
3 participants