Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(bugfix) Refactor property type in DateFilter for filtering on created_time and last_edited_time + fix documentation #317

Merged
merged 2 commits into from
Dec 14, 2023
Merged

(bugfix) Refactor property type in DateFilter for filtering on created_time and last_edited_time + fix documentation #317

merged 2 commits into from
Dec 14, 2023

Conversation

samzzi
Copy link
Contributor

@samzzi samzzi commented Dec 10, 2023

Current situation

Proposed solution

  • Check if property is timestamp and use proprtyname as type when it is

@mariosimao mariosimao self-requested a review December 14, 2023 01:15
@mariosimao mariosimao merged commit ae9dba6 into mariosimao:main Dec 14, 2023
4 of 6 checks passed
@mariosimao
Copy link
Owner

Released v1.12.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariosimao mariosimao mariosimao approved these changes

Assignees

@samzzi samzzi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samzzi @mariosimao