Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker machine inspection response failure #90

Closed
Jacob-Morgan opened this issue Jul 24, 2019 · 2 comments
Closed

Docker machine inspection response failure #90

Jacob-Morgan opened this issue Jul 24, 2019 · 2 comments
Assignees
@mariotoffia
Labels
bug under-investigation A investigation is made around the issue waiting-for-feedback Waiting for someone to give feedback until this issue can be brought further.
Projects
FluentDocker

Comments

@Jacob-Morgan
Copy link

Jacob-Morgan commented Jul 24, 2019 •
edited by mariotoffia
Loading

Docker machine created using the generic driver with option --generic-ip-address=docker causes a failure in the machine inspection response parser.

IpAddress = string.IsNullOrEmpty(ip) ? IPAddress.None : IPAddress.Parse(ip),

Inspecting the docker machine using docker-machine inspect docker results in the following output, as you can the IPAddress in fact the hostname docker and not an IP address.

{
    "ConfigVersion": 3,
    "Driver": {
        "IPAddress": "docker",
        "MachineName": "docker",
        "SSHUser": "pharos",
        "SSHPort": 22,
        "SSHKeyPath": "",
        "StorePath": "/home/pharos/.docker/machine",
        "SwarmMaster": false,
        "SwarmHost": "",
        "SwarmDiscovery": "",
        "EnginePort": 2376,
        "SSHKey": ""
    },
    "DriverName": "generic",
    "HostOptions": {
        "Driver": "",
        "Memory": 0,
        "Disk": 0,
        "EngineOptions": {
            "ArbitraryFlags": [],
            "Dns": null,
            "GraphDir": "",
            "Env": [],
            "Ipv6": false,
            "InsecureRegistry": [],
            "Labels": [],
            "LogLevel": "",
            "StorageDriver": "overlay2",
            "SelinuxEnabled": false,
            "TlsVerify": true,
            "RegistryMirror": [],
            "InstallURL": "https://get.docker.com"
        },
        "SwarmOptions": {
            "IsSwarm": false,
            "Address": "",
            "Discovery": "",
            "Agent": false,
            "Master": false,
            "Host": "tcp://0.0.0.0:3376",
            "Image": "swarm:latest",
            "Strategy": "spread",
            "Heartbeat": 0,
            "Overcommit": 0,
            "ArbitraryFlags": [],
            "ArbitraryJoinFlags": [],
            "Env": null,
            "IsExperimental": false
        },
        "AuthOptions": {
            "CertDir": "/home/pharos/.docker/machine/certs",
            "CaCertPath": "/home/pharos/.docker/machine/certs/ca.pem",
            "CaPrivateKeyPath": "/home/pharos/.docker/machine/certs/ca-key.pem",
            "CaCertRemotePath": "",
            "ServerCertPath": "/home/pharos/.docker/machine/machines/docker/server.pem",
            "ServerKeyPath": "/home/pharos/.docker/machine/machines/docker/server-key.pem",
            "ClientKeyPath": "/home/pharos/.docker/machine/certs/key.pem",
            "ServerCertRemotePath": "",
            "ServerKeyRemotePath": "",
            "ClientCertPath": "/home/pharos/.docker/machine/certs/cert.pem",
            "ServerCertSANs": [],
            "StorePath": "/home/pharos/.docker/machine/machines/docker"
        }
    },
    "Name": "docker"
}
@Jacob-Morgan Jacob-Morgan changed the title Docker machine inspection response failure with IPAddress Docker machine inspection response failure Jul 24, 2019
@mariotoffia mariotoffia self-assigned this Jul 24, 2019
@mariotoffia mariotoffia added bug under-investigation A investigation is made around the issue labels Jul 24, 2019
@mariotoffia mariotoffia added this to To do in FluentDocker via automation Jul 24, 2019
mariotoffia pushed a commit that referenced this issue Jul 24, 2019
Fixed bug (Issue #90) and added ulimit feature (Issue #88).
a1f821b 
The bug is when docker-machine was created using --generic-ip-address=docker where it will have docker as the ipaddress.

Now it is possible to set ulimit on ContainerCreateParams and on
the fluent API.
@mariotoffia
Copy link
Owner

@Jacob-Morgan Do you have the possibility to checkout the master branch and test this fix? Otherwise I'll test it later on before releasing.

Cheers,
Mario

@mariotoffia mariotoffia added the waiting-for-feedback Waiting for someone to give feedback until this issue can be brought further. label Jul 29, 2019
@Jacob-Morgan
Copy link
Author

I no longer see the problem with the latest update.

FluentDocker automation moved this from To do to Done Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mariotoffia mariotoffia

Labels
bug under-investigation A investigation is made around the issue waiting-for-feedback Waiting for someone to give feedback until this issue can be brought further.
Projects
FluentDocker
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jacob-Morgan @mariotoffia