Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetworkLs: Fix parsing of CreatedAt #144

Merged
merged 3 commits into from
Dec 18, 2019
Merged

NetworkLs: Fix parsing of CreatedAt #144

merged 3 commits into from
Dec 18, 2019

Conversation

truepele
Copy link
Contributor

NetworkLs: Fix parsing of CreatedAt DateTime

  • Move parsing logic out of Network class to a parser
  • Fix parser to support negative timezones for CreatedAt date

See #143

truepele and others added 3 commits December 17, 2019 22:47
@truepele
Merge pull request #3 from mariotoffia/master
123f1d2 
merge from mariotoffia/master
@truepele
NetworkLs: Fix parsing of created date
de24b17 
- Move parsing logic out of Network class to a parser
- Fix NetworkLs to support negative timezones for CreatedAt date
@truepele
fix formatting
61a1784
@mariotoffia
Copy link
Owner

Thanks for this PR!! :)

@mariotoffia mariotoffia merged commit 0999a05 into mariotoffia:master Dec 18, 2019
@truepele
Copy link
Contributor Author

Thanks for this PR!! :)

Thank you!

@truepele truepele deleted the feature-fix-network-ls-date-parse branch December 18, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@truepele @mariotoffia