Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add features to Docker FileBuilder #180

Merged
merged 4 commits into from
Mar 17, 2021
Merged

Add features to Docker FileBuilder #180

merged 4 commits into from
Mar 17, 2021

Conversation

mariotoffia
Copy link
Owner

@mariotoffia mariotoffia commented Mar 17, 2021 •
edited
Loading

This PR adds a few enhancements to the FileBuilder to support a few issues and a bit more (while implementing it).

This adds the following commands:

  • ENV
  • ARG
  • ENTRYPOINT
  • LABEL
  • USER
  • VOLUME

Via the Model/Builder/FileBuilder/ICommand structure.

Modified:

  • FROM to accept both platform (such as linux/amd64) and a alias name. This name may be referred using other commands.
  • COPY to accept chown user and group as well as --from=alias to refer to a earlier build step FROM ... AS alias.

TODO: Add description when committing the rest.

This closes #177 when done. It also closes #178. In addition it also closes #179 when it is merged.

@mariotoffia
Added several dockerfile commands for Issue #177
276065e 
ENV, ARG, ENTRYPOINT, LABEL, USER, VOLUME
@mariotoffia mariotoffia self-assigned this Mar 17, 2021
@mariotoffia mariotoffia added this to In progress in FluentDocker via automation Mar 17, 2021
@mariotoffia mariotoffia added this to the 3.0.0 milestone Mar 17, 2021
@mariotoffia mariotoffia added the under-development Denotes that a issue is under development but not yet released. label Mar 17, 2021
@mariotoffia mariotoffia merged commit 781c884 into master Mar 17, 2021
FluentDocker automation moved this from In progress to Done Mar 17, 2021
@mariotoffia mariotoffia added waiting-for-feedback Waiting for someone to give feedback until this issue can be brought further. and removed under-development Denotes that a issue is under development but not yet released. labels Mar 17, 2021
@mariotoffia mariotoffia deleted the feature-filebuilder-misc branch July 19, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mariotoffia mariotoffia

Labels
enhancement waiting-for-feedback Waiting for someone to give feedback until this issue can be brought further.
Projects
FluentDocker
  
Done
Milestone
3.0.0
1 participant
@mariotoffia