Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors.As is incorrectly used #16

Closed
mariotoffia opened this issue May 6, 2021 · 0 comments
Closed

errors.As is incorrectly used #16

mariotoffia opened this issue May 6, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@mariotoffia
Copy link
Owner

Instead of e.g.

		var resourceNotFound *smtypes.ResourceNotFoundException

		if errors.As(err, resourceNotFound) {
			return nil
		}

It should use the address to the pointer in error.As - e.g.

		var resourceNotFound *smtypes.ResourceNotFoundException

		if errors.As(err, &resourceNotFound) {
			return nil
		}
@mariotoffia mariotoffia self-assigned this May 6, 2021
@mariotoffia mariotoffia added the bug Something isn't working label May 6, 2021
mariotoffia added a commit that referenced this issue May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant