Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for syntax error overlay #32

Closed
jrysig opened this issue Dec 3, 2016 · 2 comments
Closed

Support for syntax error overlay #32

jrysig opened this issue Dec 3, 2016 · 2 comments

Comments

@jrysig
Copy link

jrysig commented Dec 3, 2016

Is it possible to support syntax error overlay in webpack-bundle?
It is implemented in webpack-hot-middleware: webpack-contrib/webpack-hot-middleware#9
or Create React App: facebook/create-react-app#744

I did try to use webpack-error-notification plugin but error overlay displayed directly in browser seems like better solution.

@mariusbalcytis
Copy link
Owner

First one, as I understand, is not compatible with webpack-dev-server, which does many more things than just hot-reloading, so taking it out and rolling out some alternative seems overkill for overlay notifications.
Second one does not come as separate component and is React specific.

Currently webpack-dev-server client displays errors in console. Maybe some abstract solution to show any console error as a browser notification etc. would be a solution?

Webpack-dev-server gives socket to listen to events (this is done by webpack-dev-server client), but I'm not sure whether it would clash with client or could work as a separate, additional library.

mariusbalcytis added a commit that referenced this issue Mar 10, 2017
@mariusbalcytis
Copy link
Owner

webpack-dev-server supports this from 2.3 version. Webpack 2 default configuration enables this automatically - just update the bundle (see upgrade.md) and run maba:webpack:setup to update package.json and webpack configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants