Support string_view parameters #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- uuid::is_valid_uuid - uuid::from_string - uuid_name_generator::operator()
|
@mariusbancila, I have also pushed a fix for the breaking TravisCI build and some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20.
Fixes #25.
Add string_view test cases for each.
Add compile-time tests for constexpr constructor and from_string.
Note API breaking change: explicit template parameters need to be changed for these functions. Eg.
uuid::is_valid_uuid<char>("{}")needs to be updated touuid::is_valid_uuid<char const *>("{}")or simply deduceduuid::is_valid_uuid("{}").