Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration: Check if the label on dataset level is needed #43

Closed
SeppPenner opened this issue Sep 30, 2019 · 7 comments
Closed

Migration: Check if the label on dataset level is needed #43

SeppPenner opened this issue Sep 30, 2019 · 7 comments
Labels
from migration These issues were migrated from Joelius300s repository and more information can be found there

Comments

@SeppPenner
Copy link
Contributor

Migrated from Joelius300/ChartJSBlazor#46:

From Joelius300/ChartJSBlazor#40 (comment):

We need to investigate whether the label on dataset basis is valid for all kind of charts.

For pie and doughnut, it has no effect: https://jsfiddle.net/g1anoety/ without the datalabels plugin enabled. (I would remove this for all charts where it's not yet needed and add it again if it's needed after we managed to get Joelius300/ChartJSBlazor#34 done).

Following https://www.chartjs.org/docs/latest/charts/:

I have asked the guys from Chart.Js to check this as well and tell us, what's the idea behind this: chartjs/Chart.js#6452.

@Joelius300 Joelius300 added the from migration These issues were migrated from Joelius300s repository and more information can be found there label Nov 14, 2019
@Joelius300
Copy link
Contributor

Thanks for the investigation. This will be respected in #96.

@SeppPenner
Copy link
Contributor Author

Please see chartjs/Chart.js#6452 (comment). I guess, this is deprecated now? That's how I understood it at least.

@Joelius300
Copy link
Contributor

I was actually quite confused by what happened in that issue. How come it's about title now? I thought this is only about the dataset label which isn't deprecated right?

@SeppPenner
Copy link
Contributor Author

You're right. I will ask them again.

@Joelius300
Copy link
Contributor

Joelius300 commented Jun 1, 2020

You don't have to.

I'm pretty sure about the labels now, your investigation already helped enough. I think they just misinterpreted the issue you posted. We should just move on, IMO it's all good.

@SeppPenner
Copy link
Contributor Author

Ok :)

@Joelius300
Copy link
Contributor

Joelius300 commented Jun 1, 2020

I see you already posted something, I guess it won't hurt 😅 but from my side, I don't think it's necessary anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from migration These issues were migrated from Joelius300s repository and more information can be found there
Projects
None yet
Development

No branches or pull requests

2 participants