-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration: Check if the label on dataset level is needed #43
Comments
Thanks for the investigation. This will be respected in #96. |
Please see chartjs/Chart.js#6452 (comment). I guess, this is deprecated now? That's how I understood it at least. |
I was actually quite confused by what happened in that issue. How come it's about title now? I thought this is only about the dataset label which isn't deprecated right? |
You're right. I will ask them again. |
You don't have to. I'm pretty sure about the labels now, your investigation already helped enough. I think they just misinterpreted the issue you posted. We should just move on, IMO it's all good. |
Ok :) |
I see you already posted something, I guess it won't hurt 😅 but from my side, I don't think it's necessary anymore. |
Migrated from Joelius300/ChartJSBlazor#46:
From Joelius300/ChartJSBlazor#40 (comment):
We need to investigate whether the label on dataset basis is valid for all kind of charts.
For
pie
anddoughnut
, it has no effect: https://jsfiddle.net/g1anoety/ without the datalabels plugin enabled. (I would remove this for all charts where it's not yet needed and add it again if it's needed after we managed to get Joelius300/ChartJSBlazor#34 done).Following https://www.chartjs.org/docs/latest/charts/:
I have asked the guys from Chart.Js to check this as well and tell us, what's the idea behind this: chartjs/Chart.js#6452.
The text was updated successfully, but these errors were encountered: