Dataset rework #112
Merged
Dataset rework #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every chart is mixable per default and mixing bar and line charts is greatly simplified by the current dataset solution. To make the other charts all mixable, some changes would be required regarding the dataset collections (we wouldn't use the concrete types). Currently, those classes don't make sense. They'll have to be reconsidered and reworked. Having some very loosely typed config objects would allow all kinds of mixing at the cost of less typesafety and guidance.
mariusmuntean
approved these changes
May 23, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96
Most relevant information can be found there.
Apart from that there are few side-effects/additional features that come with this PR. These include:
Momentwrapper. We'll just useDateTimein the future.Hiddenproperty was removed as it shouldn't be used. This adds room for implementing interop to handle that but for now, let's leave it at that.Point,TimePoint,BubblePointandFloatingBarPointare now implemented as readonly structsAs a side-note, I recently found out that Chart.js actually tracks the changes you make to the data and animates the chart accordingly on update. This would have to be implemented on dataset level. With the general structure being fixed now and a robust API in place, we can tackle this feature later on but it's not part of this PR.
fixes #49
fixes #38