Added alpha to FromColorString and ColorHexString #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joelius300
suggested changes
Jun 1, 2020
Comment on lines
+85
to
+87
| public static string FromDrawingColor(System.Drawing.Color color, byte alpha = 0) | ||
| { | ||
| return ColorHexString(color.R, color.G, color.B); | ||
| return ColorString(color.R, color.G, color.B, (double)color.A / byte.MaxValue); |
There was a problem hiding this comment.
You should probably remove the unused alpha parameter, right?
Also the summary still says "as hex" but you're using ColorString instead of ColorHexString now. You should use the newly added ColorHexString. We could also consider removing the "as hex" part in the summary and keep using ColorString but my personal preference is using ColorHexString.
| /// <returns></returns> | ||
| public static string ColorHexString(byte r, byte g, byte b, double alpha) | ||
| { | ||
| return $"#{r:X2}{g:X2}{b:X2}{(byte)(alpha * 255):X2}"; |
There was a problem hiding this comment.
Use byte.MaxValue instead of 255.
|
Coming back to the repo to do some cleaning. Have you had time to look at my review? |
|
This PR was made redundant by ea4b914. Thank you for your contribution anyway :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118