Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ineffectual assignments #29

Closed
wants to merge 1 commit into from
Closed

Remove ineffectual assignments #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions app/handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,10 +529,8 @@ func (h *handler) HandleInbox(w http.ResponseWriter, r *http.Request) {
}

baseURL, _ := url.Parse(h.conf.BaseURL)
title := fmt.Sprintf("%s: main page", baseURL.Host)

acct := account(r)
title = fmt.Sprintf("%s: followed", baseURL.Host)
title := fmt.Sprintf("%s: followed", baseURL.Host)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the moment I would prefer not to change this, even though it's definitely a bug.

The work I'm doing currently in the filtering-improvements branch involves removing all the custom handlers in favour of a generic listing one and better middleware.


filter.FollowedBy = acct.Hash.String()

Expand Down
2 changes: 1 addition & 1 deletion app/repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1243,7 +1243,7 @@ func (r *repository) LoadFollowRequests(ed *Account, f Filters) (FollowRequests,
}
}
}
requests, err = r.loadAuthors(requests...)
requests, _ = r.loadAuthors(requests...)
}
return requests, uint(len(requests)), nil
}
Expand Down