Remove ineffectual assignments #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure if we want to check for the error rather than ignoring its return value here. The error wasn't handled before, so that may as well be an oversight.
mariusor
reviewed
Jan 30, 2020
| acct := account(r) | ||
| title = fmt.Sprintf("%s: followed", baseURL.Host) | ||
| title := fmt.Sprintf("%s: followed", baseURL.Host) |
There was a problem hiding this comment.
For the moment I would prefer not to change this, even though it's definitely a bug.
The work I'm doing currently in the filtering-improvements branch involves removing all the custom handlers in favour of a generic listing one and better middleware.
|
Feel free to close this one, should you not intend to merge it at a later point. |
|
Thank you. I kind of lost track of issues like these after the merge of the filtering improvements branch. Please feel free to reopen on top of new master, if you have the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if we want to check for the error rather than
ignoring its return value here. The error wasn't handled
before, so that may as well be an oversight.