Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for tiles #15

Closed
mariusz-ostoja-swierczynski opened this issue Jan 12, 2021 · 4 comments · Fixed by #55
Closed

Support for tiles #15

mariusz-ostoja-swierczynski opened this issue Jan 12, 2021 · 4 comments · Fixed by #55
Assignees
Labels
feature New feature or request

Comments

@mariusz-ostoja-swierczynski
Copy link
Owner

No description provided.

@mariusz-ostoja-swierczynski
Copy link
Owner Author

mariusz-ostoja-swierczynski commented Nov 17, 2022

This is now done and merged to dev and will be hopefully soon merged to master.

@maciej-or I had to comment out bit of code in sensor.py:

# TODO: this sensor's ID assignment needs to be fixed as base on such ID
# tech api doesn't return value and we get KeyError
#
# class TileValveTemperatureSensor(TileSensor):

If you have time, please look on this if you can fix it.

@maciej-or
Copy link

maciej-or commented Nov 23, 2022

hi @mariusz-ostoja-swierczynski,
I've checked current dev branch. I'm not sure if it's mistake by merging or intended change but all sensors have device instances. Logically should be 1 device with multiple sensors. In my case it is 1 boiler (device) and 18 sensors (entities).

my initial PR:
image

and current dev with my boiler:
image

@jontofront
Copy link

In my case dev branch works ok,
I have 8 zones = device. One device is Boiler pump
image

@maciej-or
Copy link

maciej-or commented Nov 24, 2022

Well, I suppose it's wrong mapping to Home Assistant structures. You have 1 device (L4 controller) with 8 HVACs (zones) and 1 binary sensor or switch (pump).
see: https://www.home-assistant.io/integrations/climate
Zones should have index 1-8 and belong to the same device. Imagine you have more than one L4 controller or more than one boiler. I would expect their entities will be grouped by device.

@anarion80 anarion80 linked a pull request Mar 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants