New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply unitsMultiplier to camera points #17

Merged

mariuszhermansdorfer merged 1 commit into mariuszhermansdorfer:master from philipbelesky:master

Sep 4, 2019

Collaborator

philipbelesky commented Sep 4, 2019

The unitsMultiplier parameter was set to document units but then does not seem to have been used to scale the resulting point cloud.

There are still a few hardcoded variables that assume meters but this commit seems to get the basic dimensions scaling correctly.


          Apply unitsMultiplier to camera points

5c5c191

mariuszhermansdorfer approved these changes

View reviewed changes

Owner

mariuszhermansdorfer left a comment

Thanks, I had it working on my local machine. Must have forgotten to update this part of code...

mariuszhermansdorfer merged commit 1e34655 into mariuszhermansdorfer:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment