Feature/#25 tokens #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the component closes to more easily setup shared logic for the new components added in #44 #24 and #25. It includes a basic implementation of #25, but the output currently needs to be refined for accuracy. Component signatures will have changed so existing definitions will likely need updating.
Basically there is a shared
BaseCompoonentclass for logging/timed solves and further base classes for depth processing and pixel processing.Submitting this now in order to start work on #61 and to try and prevent future messy merges. If/when merged I'd be happy to go through and update #44 to use the same structure so that it can be merged cleanly.