Procedures input and output parameters do not support TYPE OF COLUMN #169

luronumen · 2021-02-16T14:25:37Z

ACTUAL RESULT

Procedures input and output parameters do not support TYPE OF COLUMN:

ALTER PROCEDURE USER_SEARCH (
ID BIGINT )
RETURNS (
USER_NAME VARCHAR(32),
FIRST_NAME VARCHAR(32),
LAST_NAME VARCHAR(32),
SITE_ID BIGINT,
DBA TYPE OF VISIBLE,
KEEPALIVE_TIME TIMESTAMP,
VISIBLE TYPE OF VISIBLE,
FULL_NAME VARCHAR(100) )

EXPECTED RESULT

Procedures input and output parameters should support TYPE OF COLUMN:

ALTER PROCEDURE USER_SEARCH (
ID TYPE OF COLUMN USERS.ID )
RETURNS (
USER_NAME TYPE OF COLUMN USERS.USER_NAME,
FIRST_NAME TYPE OF COLUMN USERS.FIRST_NAME,
LAST_NAME TYPE OF COLUMN USERS.LAST_NAME,
SITE_ID TYPE OF COLUMN USERS.SITE_ID,
DBA TYPE OF COLUMN USERS.DBA,
KEEPALIVE_TIME TYPE OF COLUMN USERS.KEEPALIVE_TIME,
VISIBLE OF COLUMN USERS.VISIBLE,
FULL_NAME TYPE OF COLUMN USERS.FULL_NAME )

STEPS TO REPRODUCE THIS ISSUE
1- Create a Firebird 3.0 database with the following DDL instruction: FB30_DDL.txt

ISSUE 1:
Right mouse click on USER_SEARCH procedure and then select Alter; input and output parameters are not showed as TYPE OF COLUMN
ISSUE 2:
Double mouse click on USER_SEARCH procedure to Open the procedure property; input and output parameters are not showed as TYPE OF COLUMN.

IMPORTANT NOTES
For more details about the Use of Column Type in Declarations please check:
https://firebirdsql.org/file/documentation/html/en/refdocs/fblangref25/firebird-25-language-reference.html#fblangref25-ddl-proc-paramscoltype

…TYPE OF COLUMN mariuz#169 - Wrong "Create Selectable SP" and "Create Selectable EB" output mariuz#78

luronumen · 2021-03-04T09:05:53Z

Retest result on FlameRobin v0.9.3.7: FAILED!

ACTUAL RESULT

Not all input and output parameters are supporting TYPE OF COLUMN:

ALTER PROCEDURE USER_SEARCH (
ID BIGINT )
RETURNS (
USER_NAME VARCHAR(32),
FIRST_NAME VARCHAR(32),
LAST_NAME VARCHAR(32),
SITE_ID BIGINT,
DBA TYPE OF COLUMN USERS.DBA,
KEEPALIVE_TIME TIMESTAMP,
VISIBLE TYPE OF COLUMN USERS.VISIBLE,
FULL_NAME VARCHAR(100) )

…ariuz#169

arvanus · 2021-05-20T15:21:47Z

@Jdochoa
Expected:

create or alter function FN_NAME (
    FIELD1 MYDOMAN)
returns OTHERDOMAIN
as
declare variable variable ANOTHERDOMAIN;
begin
end

Actual:

create or alter function FN_NAME (
    FIELD1 TYPE OF COLUMN NUMERIC(14,0) )
RETURNS   OTHERDOMAIN
AS
declare variable type of ANOTHERDOMAIN;
BEGIN
END

Jdochoa · 2021-05-22T05:32:11Z

@Jdochoa
Expected:

create or alter function FN_NAME (
    FIELD1 MYDOMAN)
returns OTHERDOMAIN
as
declare variable variable ANOTHERDOMAIN;
begin
end

Actual:

create or alter function FN_NAME (
    FIELD1 TYPE OF COLUMN NUMERIC(14,0) )
RETURNS   OTHERDOMAIN
AS
declare variable type of ANOTHERDOMAIN;
BEGIN
END

Hi @arvanus.

i can't reproduce it, do you have more information?

./jo

luronumen · 2021-05-22T11:02:05Z

@Jdochoa
Expected:

create or alter function FN_NAME (
    FIELD1 MYDOMAN)
returns OTHERDOMAIN
as
declare variable variable ANOTHERDOMAIN;
begin
end

Actual:

create or alter function FN_NAME (
    FIELD1 TYPE OF COLUMN NUMERIC(14,0) )
RETURNS   OTHERDOMAIN
AS
declare variable type of ANOTHERDOMAIN;
BEGIN
END

Hi @arvanus

Using this flamerobin.7z I also NOT able to reproduce the issue that you mentioned. Which Firebird version are you using?

arvanus · 2021-05-24T00:30:53Z

Sorry, forgot to mention "type of", try with these:


SET TERM ^ ;

create or alter function DUMMY_FN (
    NEW_PARAM type of MYDOMAN)
returns integer
as
begin
  /* Function Text */
  return 1;
end^

SET TERM ; ^

luronumen · 2021-05-25T10:40:32Z

Sorry, forgot to mention "type of", try with these:


SET TERM ^ ;

create or alter function DUMMY_FN (
    NEW_PARAM type of MYDOMAN)
returns integer
as
begin
  /* Function Text */
  return 1;
end^

SET TERM ; ^

Hi @arvanus

I can now reproduce the issue that you mentioned.

Best regards,
Luciano

…mariuz#169

Jdochoa · 2021-05-25T18:11:50Z

Sorry, forgot to mention "type of", try with these:


SET TERM ^ ;

create or alter function DUMMY_FN (
    NEW_PARAM type of MYDOMAN)
returns integer
as
begin
  /* Function Text */
  return 1;
end^

SET TERM ; ^

Fix it.

luronumen · 2021-05-25T20:38:29Z

Hi @Jdochoa

Could you generate a new build of FlameRobin so that I can help in validating the open issue?

Thanks in advance,
Luciano

Jdochoa · 2021-05-25T20:53:33Z

Luciano

flamerobin.zip

./jo

arvanus · 2021-05-25T21:05:22Z

Looks Fixed to me

luronumen · 2021-05-28T11:05:07Z

Luciano

flamerobin.zip

./jo

Hi @Jdochoa

This FlameRobin version do not list the procedures Input/Output parameters:

Jdochoa · 2021-05-28T17:42:12Z

Luciano

flamerobin.zip
./jo

Hi @Jdochoa

This FlameRobin version do not list the procedures Input/Output parameters:

Hi @luronumen.

I can't reproduce it, please verify your preferences

Or wait the next snapshot.

luronumen · 2021-05-28T19:57:03Z

Hi @Jdochoa

After set Show columns and parameters in tree this issue is NOT reproducible!
Thank you very much!

Best regards,
Luciano

luronumen · 2021-05-28T20:26:15Z

Hi @Jdochoa

Retest result on flamerobin.zip:

ISSUE 1: FIXED!
ISSUE 2: It is still reproducible:

Jdochoa · 2021-06-07T01:41:08Z

Hi @Jdochoa

Retest result on flamerobin.zip:
* ISSUE 1: FIXED!

* ISSUE 2: It is still reproducible:

Hi @luronumen.

I'm not sure about this, Flamerobin behaves like this:
In the preferences

If Only Show Datatype is checked, show this.

If Only Show domains is checked, show this.

If Show Boot domain and Datatype is checked, show this

In which scenario should I check type of?

./jo

luronumen · 2021-06-07T02:14:17Z

Hi @Jdochoa

For the fields of a procedure that are defined as a TYPE OF COLUMN instead of the traditional field types (varchar, int, float, etc) I think it makes more sense to always show < tablename > . < columnname > instead of the traditional types (varchar, int, float, etc.)

Based on this I believe that we should check if a field of a procedure is TYPE OF COLUMN in all three possibilities:

Only show datatype
Only show domain
Show Both domain and datatype

Does it make sense to you too?

- Procedures input and output parameters do not support TYPE OF COLUMN mariuz#169

Jdochoa · 2021-06-12T05:58:52Z

Hi @Jdochoa

For the fields of a procedure that are defined as a TYPE OF COLUMN instead of the traditional field types (varchar, int, float, etc) I think it makes more sense to always show < tablename > . < columnname > instead of the traditional types (varchar, int, float, etc.)

Based on this I believe that we should check if a field of a procedure is TYPE OF COLUMN in all three possibilities:
* Only show datatype

* Only show domain

* Show Both domain and datatype
Does it make sense to you too?

Hi @luronumen

It is modified so that instead of DataType, typeOf is displayed, please review at https://github.com/Jdochoa/flamerobin.git

./jo

luronumen · 2021-06-12T14:14:36Z

Hi @Jdochoa

Could you generate a new build of FlameRobin so that I can validating the fix?

Thanks in advance,
Luciano

luronumen · 2021-06-12T14:25:25Z

Hi @Jdochoa

I got to retest using the build that you mentioned on #210

Is it possible to show only TABLE.COLUMN instead of TYPE OF COLUMN TABLE.COLUMN?

luronumen · 2021-06-13T12:27:18Z

Hi @Jdochoa

The build that you mentioned on #210 is showing the following issue when I try to select the Functions Dependencies tab:

Jdochoa · 2021-06-14T06:04:49Z

Hi @Jdochoa

The build that you mentioned on #210 is showing the following issue when I try to select the Functions Dependencies tab:

Thank you @luronumen, Fix it.

./jo

Jdochoa · 2021-06-14T06:15:13Z

Hi @Jdochoa

I got to retest using the build that you mentioned on #210

Is it possible to show only TABLE.COLUMN instead of TYPE OF COLUMN TABLE.COLUMN?

Hi @luronumen

It's possible, but not easy. we need some changes in the datatypes.
You decide if waiting or rollback the change.

./jo

luronumen · 2021-06-14T10:45:11Z

Hi @Jdochoa

No problem for me to wait.
As soon as you have a version that fixes all these issue, please share the build here so I can help you to retest it.
Thank you very much for the great job you've done to modernize FlameRobin.
Lets fix all the issues, complete support for Firebird 3.0, and then move on to Firebird 4.0.

Best Regards,
Luciano

arvanus · 2021-06-14T11:20:12Z

Hello everyone
I would create a new column "Type of", that receives a Boolean value (checkbox), like IBexpert does. What do you think?

luronumen · 2021-06-14T12:49:41Z

Hello everyone
I would create a new column "Type of", that receives a Boolean value (checkbox), like IBexpert does. What do you think?

Hi @arvanus

Did you mean replace the true/false strings in the grid with a checkbox in the Boolean type representation?
That would be wonderful!

Best Regards,
Luciano

arvanus · 2021-06-14T12:59:01Z

I mean like this:

luronumen · 2021-06-14T13:29:44Z

Now I understand @arvanus !
In this case I think it would be better to just put a column called Type of Column/Domain between the Type and Not Null columns. What do you think?

Jdochoa · 2021-06-14T16:41:57Z

Now I understand @arvanus !
In this case I think it would be better to just put a column called Type of Column/Domain between the Type and Not Null columns. What do you think?

Hi @arvanus
do you explain the functionality?

./jo

arvanus · 2021-06-14T22:26:32Z

Sorry @Jdochoa, I didn't understand what you meant
Today Flamerobin show the data in a different way comparing to IBExpert, FR simply shows the type(DOMAIN) together, while IB splits the data. I'd do the same as IB, splitting Type into 3 columns: Type, Type of, Domain/Column
Another alternative, is to keep "Type" as is (without the text TYPE OF), and simply add a column "Type of" as a boolean between "parameter" and "Type"

luronumen · 2021-06-15T10:54:38Z

Hi @arvanus and @Jdochoa

What do you think about this two columns:

Type: Always show the native type of the Procedure/Function parameter (BIGINT, VARCHAR, BOOLEAN, etc);
Type of Column/Domain: Show domain or table column if Procedure/Function parameter is of this type;

luronumen · 2021-06-26T12:20:31Z

Hi @Jdochoa

The following issue is happening when I try to delete a record:

…LUMN mariuz#169

luronumen · 2022-06-27T15:00:48Z

Retest result on FlameRobin 0.9.3.12: PASS!
Thank you very much for the fix!

Best Regards,
Luciano

* master: (30 commits) Update codeql-analysis.yml Update _ibpp.cpp Update fr_settings.confdef Fix NO PAD collation bug Fix minor error. Update ExecuteSqlFrame.cpp Fix: mariuz#260 Fix mariuz#68 minor fix Show error msg when save SQL file failed configuration for FB library is added (Application level) Library per conexión Add 32768 for restore with Firebird 4 mariuz#242 Import patchs from IBPP in SourceForge mariuz#215 Alter Database Linger value mariuz#217 Increment year to 2022 Fix: Cosmetic issue with full DDL extraction mariuz#243 Fix: Incorrect trigger state display mariuz#252 Fix: Primary Keys and Foreign Keys are not listed on Indexes node mariuz#180 Fix: Procedures input and output parameters do not support TYPE OF COLUMN mariuz#169 ...

Jdochoa added a commit to Jdochoa/flamerobin that referenced this issue Mar 1, 2021

- Procedures and Function input and output parameters do not support …

faa7e21

…TYPE OF COLUMN mariuz#169 - Wrong "Create Selectable SP" and "Create Selectable EB" output mariuz#78

Jdochoa added a commit to Jdochoa/flamerobin that referenced this issue Mar 5, 2021

Procedures input and output parameters do not support TYPE OF COLUMN m…

a4fb679

…ariuz#169

Jdochoa added a commit to Jdochoa/flamerobin that referenced this issue May 25, 2021

- Procedures input and output parameters do not support TYPE OF COLUMN …

c8340f1

…mariuz#169

Jdochoa added a commit to Jdochoa/flamerobin that referenced this issue Jun 12, 2021

It is modified so that instead of DataType, typeOf is displayed

cc42952

- Procedures input and output parameters do not support TYPE OF COLUMN mariuz#169

Jdochoa added a commit to Jdochoa/flamerobin that referenced this issue Mar 4, 2022

Fix: Procedures input and output parameters do not support TYPE OF CO…

7925372

…LUMN mariuz#169

luronumen closed this as completed Jun 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Procedures input and output parameters do not support TYPE OF COLUMN #169

Procedures input and output parameters do not support TYPE OF COLUMN #169

luronumen commented Feb 16, 2021 •

edited

Loading

luronumen commented Mar 4, 2021

arvanus commented May 20, 2021

Jdochoa commented May 22, 2021

luronumen commented May 22, 2021

arvanus commented May 24, 2021

luronumen commented May 25, 2021

Jdochoa commented May 25, 2021

luronumen commented May 25, 2021

Jdochoa commented May 25, 2021

arvanus commented May 25, 2021

luronumen commented May 28, 2021

Jdochoa commented May 28, 2021

luronumen commented May 28, 2021

luronumen commented May 28, 2021

Jdochoa commented Jun 7, 2021

luronumen commented Jun 7, 2021 •

edited

Loading

Jdochoa commented Jun 12, 2021

luronumen commented Jun 12, 2021

luronumen commented Jun 12, 2021

luronumen commented Jun 13, 2021

Jdochoa commented Jun 14, 2021

Jdochoa commented Jun 14, 2021

luronumen commented Jun 14, 2021

arvanus commented Jun 14, 2021

luronumen commented Jun 14, 2021

arvanus commented Jun 14, 2021

luronumen commented Jun 14, 2021

Jdochoa commented Jun 14, 2021

arvanus commented Jun 14, 2021

luronumen commented Jun 15, 2021

luronumen commented Jun 26, 2021

luronumen commented Jun 27, 2022

Procedures input and output parameters do not support TYPE OF COLUMN #169

Procedures input and output parameters do not support TYPE OF COLUMN #169

Comments

luronumen commented Feb 16, 2021 • edited Loading

luronumen commented Mar 4, 2021

arvanus commented May 20, 2021

Jdochoa commented May 22, 2021

luronumen commented May 22, 2021

arvanus commented May 24, 2021

luronumen commented May 25, 2021

Jdochoa commented May 25, 2021

luronumen commented May 25, 2021

Jdochoa commented May 25, 2021

arvanus commented May 25, 2021

luronumen commented May 28, 2021

Jdochoa commented May 28, 2021

luronumen commented May 28, 2021

luronumen commented May 28, 2021

Jdochoa commented Jun 7, 2021

luronumen commented Jun 7, 2021 • edited Loading

Jdochoa commented Jun 12, 2021

luronumen commented Jun 12, 2021

luronumen commented Jun 12, 2021

luronumen commented Jun 13, 2021

Jdochoa commented Jun 14, 2021

Jdochoa commented Jun 14, 2021

luronumen commented Jun 14, 2021

arvanus commented Jun 14, 2021

luronumen commented Jun 14, 2021

arvanus commented Jun 14, 2021

luronumen commented Jun 14, 2021

Jdochoa commented Jun 14, 2021

arvanus commented Jun 14, 2021

luronumen commented Jun 15, 2021

luronumen commented Jun 26, 2021

luronumen commented Jun 27, 2022

luronumen commented Feb 16, 2021 •

edited

Loading

luronumen commented Jun 7, 2021 •

edited

Loading