Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix toggle #7

Closed
KittyGiraudel opened this issue Oct 1, 2013 · 1 comment
Closed

Fix toggle #7

KittyGiraudel opened this issue Oct 1, 2013 · 1 comment
Assignees
@mark-rolich

Comments

@KittyGiraudel
Copy link

When toggling the bookmarklet on and off, it basically changes the display of both .ruler elements from none to block and vice versa. Any chance you could change the display value of their parent (.rg-overlay) instead?

Currently, it makes the site unsable as soon as you have enabled the bookmarklet once, even if you have used it again in order to turn it off. This because the full screen overlay remains and prevents the site below from being used.

Using pointer-events: none could be a solution if you have some solid reasons not to move the show/hide to the parent.

Thanks!
@ghost ghost assigned mark-rolich Oct 1, 2013
@mark-rolich
Copy link
Owner

Thanks for pointing out that.
Overlay is toggled on "Toggle rulers and guides" and on bookmarklet click.

pull bot pushed a commit to dk-dev/RulersGuides.js that referenced this issue Apr 16, 2020
Add main menu
d546172 
Add snap to functionality
Fix toggle (mark-rolich#7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mark-rolich mark-rolich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mark-rolich @KittyGiraudel