Skip to content

Commit

Permalink
Extra comments / rewording in header.
Browse files Browse the repository at this point in the history
  • Loading branch information
@markahesketh
markahesketh committed Jul 11, 2012
1 parent a306143 commit 160a69a
Showing 1 changed file with 56 additions and 56 deletions.
112 changes: 56 additions & 56 deletions header.tpl
View file
@@ -1,82 +1,82 @@
{*
* =|= Header ===================================================
*
* <head>, top <body> content and left sidebar.
* Included on every page.
* ==============================================================
*}
* =|= Header ===================================================
*
* <head>, top <body> content and left sidebar.
* Included on every page.
* ==============================================================
*}

<!DOCTYPE html>
{* Stop conditional comments blocking downloads (Ref: http://bit.ly/LXcukK) *}
<!--[if IE]><![endif]-->
<html lang="{$meta_language}">
<head>
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1">
<!DOCTYPE html>
{* Stop conditional comments blocking downloads. (http://bit.ly/LXcukK) *}
<!--[if IE]><![endif]-->
<html lang="{$meta_language}">
<head>
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1">

{* Title set in Back Office > Preferences > SEO & URLs. *}
<title>{$meta_title|escape:'htmlall':'UTF-8'}</title>
{* Title set in Back Office > Preferences > SEO & URLs. *}
<title>{$meta_title|escape:'htmlall':'UTF-8'}</title>

{* Meta description for SERPs. *}
{if isset($meta_description) AND $meta_description}
{* Meta description for SERPs. *}
{if isset($meta_description) AND $meta_description}
<meta name="description" content="{$meta_description|escape:html:'UTF-8'}" />
{/if}
{/if}

{* Keywords are nearly useless these days, but PrestaShop has the functionality and some clients may require them. (Ref: http://bit.ly/P4FuYL) *}
{if isset($meta_keywords) AND $meta_keywords}
{* Prestashop supports meta keywords, so little harm in including them here. (http://bit.ly/P4FuYL) *}
{if isset($meta_keywords) AND $meta_keywords}
<meta name="keywords" content="{$meta_keywords|escape:html:'UTF-8'}" />
{/if}
{/if}

{* Set robots based upon Back Office config. Don't forget to generate a robots.txt too. *}
<meta name="robots" content="{if isset($nobots)}no{/if}index,{if isset($nofollow) && $nofollow}no{/if}follow" />
{* Favicon is displayed in address bar and bookmark bars in visitor's browser. (Ref: http://bit.ly/P4F7xg) *}
<link rel="icon" href="{$favicon_url}?{$img_update_time}">
{* Robots settings set in Back office. Don't forget to generate a robots.txt too. *}
<meta name="robots" content="{if isset($nobots)}no{/if}index,{if isset($nofollow) && $nofollow}no{/if}follow" />

{* Favicon displayed in address bar, tabs and bookmarks. (http://bit.ly/P4F7xg) *}
<link rel="icon" href="{$favicon_url}?{$img_update_time}">

{* Include all CSS files from page controller's SetMedia() *}
{if isset($css_files)}
{* Include all CSS files from page controller's SetMedia() *}
{if isset($css_files)}
{foreach from=$css_files key=css_uri item=media}
<link href="{$css_uri}" rel="stylesheet" type="text/css" media="{$media}" />
<link href="{$css_uri}" rel="stylesheet" type="text/css" media="{$media}" />
{/foreach}
{/if}
{/if}

{* Required Prestashop JavaScript configuration. *}
<script type="text/javascript">
var baseDir = '{$content_dir}';
var static_token = '{$static_token}';
var token = '{$token}';
{* Required Prestashop JavaScript configuration. *}
<script type="text/javascript">
var baseDir = '{$content_dir}';
var static_token = '{$static_token}';
var token = '{$token}';
var priceDisplayPrecision = {$priceDisplayPrecision*$currency->decimals};
var priceDisplayMethod = {$priceDisplay};
var roundMode = {$roundMode};
</script>
var priceDisplayMethod = {$priceDisplay};
var roundMode = {$roundMode};
</script>

{* Include all JavaScript files from page controller's SetMedia(). *}
{if isset($js_files)}
{* Include all JavaScript files from page controller's SetMedia(). *}
{if isset($js_files)}
{foreach from=$js_files item=js_uri}
<script type="text/javascript" src="{$js_uri}"></script>
<script type="text/javascript" src="{$js_uri}"></script>
{/foreach}
{/if}
{/if}

{* IE9.js makes older versions of Internet Explorer behave like a standards-compliant browser. (Ref: http://bit.ly/LX9ox0) *}
<!--[if lt IE 9]><script src="http://ie7-js.googlecode.com/svn/version/2.1(beta4)/IE9.js"></script><![endif]-->
{* IE9.js makes older versions of Internet Explorer more standards-compliant. (http://bit.ly/LX9ox0) *}
<!--[if lt IE 9]><script src="http://ie7-js.googlecode.com/svn/version/2.1(beta4)/IE9.js"></script><![endif]-->

{* HTML5Shiv enables HTML5 elements in older versions of Internet Explorer (Ref: http://bit.ly/LX9S6f) *}
<!--[if lt IE 9]><script src="//html5shim.googlecode.com/svn/trunk/html5.js"></script><![endif]-->
{* HTML5Shiv enables HTML5 elements in older versions of Internet Explorer. (http://bit.ly/LX9S6f) *}
<!--[if lt IE 9]><script src="//html5shim.googlecode.com/svn/trunk/html5.js"></script><![endif]-->

{* Header modules hook *}
{$HOOK_HEADER}
</head>
<body {if isset($page_name)}id="{$page_name|escape:'htmlall':'UTF-8'}"{/if}>
{if !$content_only}
{* Header modules hook *}
{$HOOK_HEADER}
</head>

<body {if isset($page_name)}id="{$page_name|escape:'htmlall':'UTF-8'}"{/if}>
{if !$content_only}
{if isset($restricted_country_mode) && $restricted_country_mode}
<div id="restricted-country">
<p>{l s='You cannot place a new order from your country.'} <span class="bold">{$geolocation_country}</span></p>
</div>
{/if}
<div id="page" class="container_9 clearfix">

<!-- Header -->
{* Header *}
<div id="header" class="grid_9 alpha omega">
<a id="header_logo" href="{$base_dir}" title="{$shop_name|escape:'htmlall':'UTF-8'}">
<img class="logo" src="{$logo_url}" alt="{$shop_name|escape:'htmlall':'UTF-8'}" {if $logo_image_width}width="{$logo_image_width}"{/if} {if $logo_image_height}height="{$logo_image_height}" {/if} />
Expand All @@ -87,11 +87,11 @@
</div>

<div id="columns" class="grid_9 alpha omega clearfix">
<!-- Left -->
{* Left sidebar *}
<div id="left_column" class="column grid_2 alpha">
{$HOOK_LEFT_COLUMN}
</div>

<!-- Center -->
{* Center content *}
<div id="center_column" class=" grid_5">
{/if}
{/if}

6 comments on commit 160a69a

@wujekbogdan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you dont' nead html5.js if IE9.js is used

@markahesketh
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think this was the case? See: http://stackoverflow.com/questions/3855294/html5shiv-vs-dean-edwards-ie7-js-vs-modernizr-which-to-choose/3855343#3855343

@wujekbogdan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IE9.js adds support for HTML5 elements, so you don't need to include html5.js

BTW in my opinion adding IE9.js by default is not a good idea. Some fixes done by this library can be confusing for less experienced developers. I would use only html.5 js to enable html5 elements for older borwsers. Eventualy html5.js + selectivizr http://selectivizr.com/

//edit:
consider using conditional classes for html tag: http://paulirish.com/2008/conditional-stylesheets-vs-css-hacks-answer-neither/

@markahesketh
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally I'd included IE7.js which I usually use, but bumped it up to IE9.js honestly not thinking too much about the consequences. It sounds like replacing IE9.js with Selectivizr would be a good idea so theres no so much cross-over.

Regarding the <html> tag, this is just a personal preference of mine as I used to include this in the past, but found that in practice I never needed to use the .ie7 class etc in my CSS and just dropped the whole thing. In a similar way I've never relied on browser-specific CSS files. Do you think people will benefit from it being included?

@markahesketh
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about it, its probably a good idea to follow HTML5Boilerplate or similar near exactly, as there's a lot of smart people behind it and there are researched/tested reasons they included certain things.

@wujekbogdan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion it's a good idea to follow html5boilerplate or html5reset http://html5reset.org/ (personaly i prefer the second one). as you said there's a lot of smart people behind it ;)

Please sign in to comment.