Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow blocks on Faraday connections #1

Merged
merged 5 commits into from
Feb 6, 2015
Merged

Allow blocks on Faraday connections #1

merged 5 commits into from
Feb 6, 2015

Commits on Jan 29, 2015

  1. Configuration menu
    Copy the full SHA
    a3c5ffd View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2015

  1. Add support for options! method.

    Since Faraday doesn't support the `options` request as a first class
    HTTP method (see lostisland/faraday#305) we need to use the `run_request`
    method instead of the `options` one.
    nhocki committed Feb 5, 2015
    Configuration menu
    Copy the full SHA
    1980bd0 View commit details
    Browse the repository at this point in the history
  2. Test that blocks are being passed to bang methods

    I decided to raise errors since it was the only thing I could think of
    to test without having false possitives, since `assert true` won't fail
    if the test is not passed.
    nhocki committed Feb 5, 2015
    Configuration menu
    Copy the full SHA
    0487f3f View commit details
    Browse the repository at this point in the history
  3. Better names and no more metaprogramming on options!.

    * Rename `handle_error` for `handle_response`
    * Remove `define_method` for the `options!` method.
    nhocki committed Feb 5, 2015
    Configuration menu
    Copy the full SHA
    ed73b9e View commit details
    Browse the repository at this point in the history
  4. Adding tests for options!

    nhocki committed Feb 5, 2015
    Configuration menu
    Copy the full SHA
    efdc498 View commit details
    Browse the repository at this point in the history