Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated Dropbox endpoints to use v2 #205

Merged
merged 2 commits into from Feb 15, 2018

Conversation

adamo57
Copy link
Collaborator

@adamo57 adamo57 commented Feb 3, 2018

  • Updates endpoints to point to the v2 of the Dropbox API

Fixes #204

@bentranter bentranter self-assigned this Feb 14, 2018
@bentranter
Copy link
Collaborator

Hey @adamo57, thanks for the PR! Looks like Dropbox might've made another change, as when I try to run this, everything works until the point where it tries to get the user in the FetchUser function in dropbox.go.

It seems like Dropbox now requires a POST request for that endpoint, so if you could change https://github.com/adamo57/goth/blob/adamo57-migrate-dropbox-endpoint/providers/dropbox/dropbox.go#L90 to use a POST request instead of the current GET, then I believe that should fix this.

@bentranter bentranter self-requested a review February 14, 2018 22:24
Copy link
Collaborator

@bentranter bentranter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropbox requires a POST request to the users/get_current_account endpoint now, see the other comment I made for more info.

@adamo57 adamo57 removed the request for review from rakesh-eltropy February 15, 2018 01:14
@adamo57
Copy link
Collaborator Author

adamo57 commented Feb 15, 2018

@bentranter mind taking a peek again please?

@bentranter
Copy link
Collaborator

Awesome, works for me now. Thanks for this!

@bentranter bentranter merged commit bc7deaf into markbates:master Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants