Provide a library interface #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove some warnings.
termwiz 0.5 switched to anyhow.
If terminfo is None, sp only renders to a single line with garbage content. Detect that and refuse to run. The problematic environment that I encountered has: - TERM=xterm - TERMINFO_DIRS=/usr/share/terminfo-backports - TERMINFO is not set - /usr/share/terminfo/x/xterm exists - /usr/share/terminfo-backports/x/xterm-256color exists The Rust `terminfo` crate does not search `/usr/share/terminfo` while ncurses does. From `man curses`, it _seems_ `/usr/share/terminfo` shouldn't be searched, if hard-coded.
This adds a bit more flexibility.
This adds a bit flexibility and improves portability.
Expose key features (pager with streams) via the `Pager` struct. This allows applications to setup the pager using native Rust streams (ex. impl Read), and start a pager without forking. The `lib.rs` is copied from `main.rs`. I didn't figure out a way to make git realize it is a copy without using merge commits.
The example is similar to streams_example.sh, but written in pure Rust.
quark-zju
force-pushed
the
as-library
branch
2 times, most recently
from
012ceb1
to
bc04a2a
Compare
|
Looks great! I'll make |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR did some cleanups and extracts sp's key features as a simple library. Applications using the library interface can avoid forking and use native Rust streams (
impl Read) instead of non-portableRawFds. An example was added to demostrate how it works.