Upgrade termwiz to 0.7 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quark-zju
force-pushed
the
termwiz-0.7
branch
from
87adedf
to
f4081dc
Compare
|
Can we remove the workaround in |
|
I thought it was already removed. I'll update the change. |
I also did a `cargo update`. This removes 30+ dependencies. Namely: - derive_builder, darling, palette - termwiz dropped them. - regex < 1.0 - termwiz updated it. - rand_core 0.3, 0.4 - only 0.5 is needed. - failure Note: aho-corasick 0.7.6 can potentailly cause regex correctness issues. The updated version 0.7.9 includes a fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes 30+ dependencies.
Note:
Internally termwiz 0.7 is buildable with buck while 0.6 cannot. So this unblocks us from vendoring sp into buck third-party.