-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for promising at organizer level #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prior to extracting from the main app we isolate the test code inside the SpecSupport namespace. this no longer serves a purpose inside the gem code so we can just remove the whole thing along with its extra complexity
also unify on variables and methods using klass instead of class
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
Example failure at load time
These calls to
promising
return the receiver. I.e.DoStep1
andDoStep2
in the example above, but also verify that the promises specified in the arguments:step_1
and:step_2
respectively, match the promises defined in each interactor.Why add this?
It's for the reader of the code in the future.
By explicitly calling out the promises, it's easier to debug where something is added in a chain.
By also verifying at load time, we ensure that the
promising
calls do not drift from the interactor promises implementation, as they raise an exception.I.e. this is enforced executable documentation.