Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support short names #17

Open
idej opened this issue May 15, 2017 · 11 comments
Open

support short names #17

idej opened this issue May 15, 2017 · 11 comments

Comments

@idej
Copy link

idej commented May 15, 2017

I think that it will be awesome to support short names as M, kk, MM for million.
What do you think?

@markburns
Copy link
Owner

Yeah maybe. What would the API for that look like?

@idej
Copy link
Author

idej commented May 17, 2017

what about a dictionary with the origin names and shortcuts? Then preprocess string and change shortcuts on origin using regexp?

@markburns
Copy link
Owner

markburns commented May 17, 2017 via email

@idej
Copy link
Author

idej commented May 17, 2017

Got it. From my point of view, it can be in in_numbers

@idej idej closed this as completed May 17, 2017
@idej idej reopened this May 17, 2017
@idej
Copy link
Author

idej commented May 19, 2017

@markburns what do you think?

@markburns
Copy link
Owner

markburns commented May 20, 2017 via email

@idej
Copy link
Author

idej commented May 20, 2017

Maybe. But for me string like one mln it is a number as a words.

@markburns
Copy link
Owner

markburns commented May 20, 2017 via email

@idej
Copy link
Author

idej commented May 20, 2017

Sorry. Output is a digit number one mln -> 1_000_000

@markburns
Copy link
Owner

markburns commented May 20, 2017 via email

@idej
Copy link
Author

idej commented May 20, 2017

So can add an option like abbreviation that will false by default. When true - use the most popular abbreviation (will be first in the list) instead of the word or use the word if no abbreviation. That's what you mean?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants