New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sizes strings so caller can can use percentages #609

Open

pureooze wants to merge 1 commit into markcellus:master from pureooze:pureooze/use-parent-size

pureooze commented Sep 28, 2023

This change lets callers use percentages for height and width so they can dynamically resize for different screen sizes.

Example:

// using percentages
<youtube-video height="100%" width="100%" src="..." controls></youtube-video>

// using exact values
<youtube-video height="800" width="500" src="..." controls></youtube-video>


          Make sizes strings so caller can can use percentages

aa3548e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment