migration for webpack4's hooks API #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will add the old code to support '<4' version. |
jahredhope
reviewed
Nov 19, 2018
There was a problem hiding this comment.
Thanks @getElementsByName , this is a valuable change. Sorry for leaving it so long.
Unfortunately there is some changes required to pass code coverage.
I'll recreate the branch myself to get this change in.
| @@ -224,4 +224,20 @@ function legacyArgsToOptions(entry, paths, locals, globals) { | |||
| }; | |||
| } | |||
|
|
|||
| function addThisCompilationHandler(compiler, callback) { | |||
| if(compiler.hooks) { | |||
| compiler.hooks.thisCompilation.tap('static-site-generator-webpack-plugin', callback); | |||
There was a problem hiding this comment.
Unfortunately coveralls will be unhappy that this line is not being tested.
To test it would require multiple versions of webpack which may get complicated.
For now I suggest we just ignore the line.
Suggested change
| compiler.hooks.thisCompilation.tap('static-site-generator-webpack-plugin', callback); | |
| /* istanbul ignore next */ | |
| compiler.hooks.thisCompilation.tap('static-site-generator-webpack-plugin', callback); |
|
|
||
| function addOptimizeAssetsHandler(compilation, callback) { | ||
| if(compilation.hooks) { | ||
| compilation.hooks.optimizeAssets.tapAsync('static-site-generator-webpack-plugin',callback); |
There was a problem hiding this comment.
As above:
Suggested change
| compilation.hooks.optimizeAssets.tapAsync('static-site-generator-webpack-plugin',callback); | |
| /* istanbul ignore next */ | |
| compilation.hooks.optimizeAssets.tapAsync('static-site-generator-webpack-plugin',callback); |
|
Duplicated and merged with #139 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.