Fix for jQuery 3.x compatibility without using 3.x migrate plugin #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalbagarcia
pushed a commit
to aalbagarcia/stellar.js
that referenced
this pull request
Apr 15, 2017
|
@mgsmus It just looks like it's failing because the automated tests are not recognizing the jQuery 3 commands like Also, the version will have to be bumped up since it looks like this change will break previous versions of stellar.js running on older versions of jQuery. |
DiogoTheCoder
approved these changes
Dec 22, 2018
|
These changes have been approved, but I cannot find an associated release. Is the tavis-ci fail blocking a release? What's happening with this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.