Adds validation message for duplicate attributes #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfix-stripe
approved these changes
May 26, 2023
rpaul-stripe
force-pushed
the
duplicate-attribute-validation
branch
from
19affb2
to
5833250
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #391. It modifies the
annotatefunction in the parser so that it appends an error to the node'serrorsarray when it detects a duplicate attribute. This does not actually change the rendering behavior of duplicate attributes—it still gives precedence to the last one added. I also added test cases to verify that this works as expected for multiple attributes in the same tag, multiple attributes in the same annotation, and multiple attributes across separate annotations on the same document node.Closes #391