Adds additional escapes to string attributes #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfix-stripe
approved these changes
Nov 27, 2023
|
Hey @rpaul-stripe 🙌 Do you plan to cut a new release with this fix anytime soon? |
|
@RomanHotsiy yep, I'm going to push out a new release today that includes this and the table schema fix. I already incremented the version in the table PR. |
|
Amazing! Thanks a lot! |
|
Thanks @rpaul-stripe ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our original Markdoc spec, we intended to support
\n,\r, and\tas valid escape characters, but we never actually got around to adding these in the parser. This PR adds proper support for them in the pegjs grammar and adds a marktest case to verify that the implementation behaves correctly.This addresses the issue reported by @emmatown in #468.
Closes #468