Skip to content

Commit

Permalink
fix: If environment variable is empty or "" then don't use.
Browse files Browse the repository at this point in the history
  • Loading branch information
andymac4182 committed Apr 27, 2023
1 parent d008f29 commit b0b7684
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion packages/lib/src/Settings.ts
Expand Up @@ -105,14 +105,26 @@ export class StaticSettingsLoader extends SettingsLoader {

export class EnvironmentVariableSettingsLoader extends SettingsLoader {
loadPartial(): Partial<ConfluenceSettings> {
return {
const initial = {
confluenceBaseUrl: process.env.CONFLUENCE_BASE_URL,
confluenceParentId: process.env.CONFLUENCE_PARENT_ID,
atlassianUserName: process.env.ATLASSIAN_USERNAME,
atlassianApiToken: process.env.ATLASSIAN_API_TOKEN,
folderToPublish: process.env.FOLDER_TO_PUBLISH,
contentRoot: process.env.CONFLUENCE_CONTENT_ROOT,
};

const result: Partial<ConfluenceSettings> = {};
for (const key in result) {
if (Object.prototype.hasOwnProperty.call(result, key)) {
const element = initial[key as keyof ConfluenceSettings];
if (element) {
result[key as keyof ConfluenceSettings] = element;
}
}
}

return result;
}
}

Expand Down

0 comments on commit b0b7684

Please sign in to comment.