Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLs with period and parantheses stop before closing parentheses #94

Closed
JeremyMahieu opened this issue Nov 3, 2020 · 3 comments
Closed

Comments

@JeremyMahieu
Copy link

JeremyMahieu commented Nov 3, 2020

Links such as

  • https://foo.com/bar.(par) result in https://foo.com/bar.(par
  • https://foo.com/bar.(par).asdf result in https://foo.com/bar.(par

For example real world links can be file shares that replace spaces in filenames with periods. (note: I have no affiliation with the link or the content, just found on google when searching for "Index of"

  • http://index-of.es/Android/Professional.Android.2.Application.Development.(Wrox,.2010,.0470565527).pdf
@nmilev-scribe
Copy link

Having the same issue.
How to reproduce:
paste the url below into the lounge demo:

https://mixpanel.com/project/2224040/view/2771788/app/insights#report/28200585/kp-is/~(columnWidths~(bar~())~description~'~displayOptions~(chartType~'line~plotStyle~'standard~analysis~'linear~value~'absolute)~sorting~(bar~(sortBy~'column~colSortAttrs~(~(sortBy~'value~sortOrder~'desc)))~line~(sortBy~'value~sortOrder~'desc~valueField~'averageValue~colSortAttrs~(~(sortBy~'value~sortOrder~'desc~valueField~'averageValue)))~table~(sortBy~'column~colSortAttrs~(~(sortBy~'label~sortOrder~'asc)))~insights-metric~(sortBy~'value~sortOrder~'desc~valueField~'totalValue~colSortAttrs~(~(sortBy~'value~sortOrder~'desc~valueField~'totalValue)))~pie~(sortBy~'value~sortOrder~'desc~valueField~'totalValue~colSortAttrs~(~(sortBy~'value~sortOrder~'desc~valueField~'totalValue))))~timeComparison~null~querySamplingEnabled~false~dashboard~(id~2868932~title~'NTRS*20*281000*29~creator_name~'Caila*20MacDonald~can_update_basic~true~can_share~true~allow_staff_override~false~is_superadmin~false)~title~'KPIs~sections~(show~(~(datase

@rlidwka
Copy link
Member

rlidwka commented Apr 19, 2022

Fixed examples like foo.(bar), foo;[bar] and similar (with punctuation followed by some sort of parenthesis).

For deeply nested parens we don't have a solution, see #23

@nmilev-scribe
Copy link

@rlidwka Which version contains this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants