Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links with parentheses are broken #4095

Closed
JeremyMahieu opened this issue Nov 3, 2020 · 9 comments
Closed

Links with parentheses are broken #4095

JeremyMahieu opened this issue Nov 3, 2020 · 9 comments
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.

Comments

@JeremyMahieu
Copy link

JeremyMahieu commented Nov 3, 2020

  • _The Lounge version: 4.2.0

When linking a url with parentheses in it (and possibly other characters) the link is presumed ended before the closing parentheses.

Example https://foo.com/bar.(par) results in a link to https://foo.com/bar.(par
The period in the example is nescessary otherwise it works correctly.

@JeremyMahieu JeremyMahieu added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Nov 3, 2020
@fnutt
Copy link
Contributor

fnutt commented Nov 3, 2020

Is this an issue for https://github.com/markdown-it/linkify-it ?

@xPaw
Copy link
Member

xPaw commented Nov 3, 2020

Yep, this issue belongs to linkify-it, and if you do create an issue there, provide real world examples of what this is actually breaking.

@xPaw xPaw closed this as completed Nov 3, 2020
@JeremyMahieu
Copy link
Author

FYI markdown-it/linkify-it#94

@xPaw
Copy link
Member

xPaw commented Nov 3, 2020

As I mentioned earlier, provide real world examples of what this is actually breaking (not foobar)

@JeremyMahieu
Copy link
Author

I cannot share the link I've found in the wild. And it would be pointless to craft a link just to prove a point so I will not provide a "real world" example.

Becides it's a perfectly valid link that actually requests a page and returns "not found".

@MiniDigger
Copy link
Contributor

wikipedia has this pretty often when multiple words have different pages
https://en.wikipedia.org/wiki/Tester_(disambiguation)
https://en.wikipedia.org/wiki/Tester_(surname)

@xPaw
Copy link
Member

xPaw commented Nov 4, 2020

These links work correctly, you can test that here: https://markdown-it.github.io/linkify-it/ (or in lounge)

I am interested in what site uses dots and parenthesis like that (linkify-it maintainer will want to know that too), because linkify-it's approach is to support reasonable real-world urls that people would share.

@MiniDigger
Copy link
Contributor

man, I would have sworn those links have issues. Ill remember this ticket the next time I stumble upon a broken link, I can't manage to break it in the demo right now.

@JeremyMahieu
Copy link
Author

JeremyMahieu commented Nov 5, 2020

Fileshare links that have the filenames in them and spaces replaced by dots for example.
Searched for "Index of" in google, and found some. Note that I have nothing to do with the link or it's content, just randomly found it on google.
http://index-of.es/Android/Professional.Android.2.Application.Development.(Wrox,.2010,.0470565527).pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

No branches or pull requests

4 participants