-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links with parentheses are broken #4095
Comments
Is this an issue for https://github.com/markdown-it/linkify-it ? |
Yep, this issue belongs to linkify-it, and if you do create an issue there, provide real world examples of what this is actually breaking. |
As I mentioned earlier, provide real world examples of what this is actually breaking (not foobar) |
I cannot share the link I've found in the wild. And it would be pointless to craft a link just to prove a point so I will not provide a "real world" example. Becides it's a perfectly valid link that actually requests a page and returns "not found". |
wikipedia has this pretty often when multiple words have different pages |
These links work correctly, you can test that here: https://markdown-it.github.io/linkify-it/ (or in lounge) I am interested in what site uses dots and parenthesis like that (linkify-it maintainer will want to know that too), because linkify-it's approach is to support reasonable real-world urls that people would share. |
man, I would have sworn those links have issues. Ill remember this ticket the next time I stumble upon a broken link, I can't manage to break it in the demo right now. |
Fileshare links that have the filenames in them and spaces replaced by dots for example. |
When linking a url with parentheses in it (and possibly other characters) the link is presumed ended before the closing parentheses.
Example
https://foo.com/bar.(par)
results in a link tohttps://foo.com/bar.(par
The period in the example is nescessary otherwise it works correctly.
The text was updated successfully, but these errors were encountered: