-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eat too much cpu on 3.0.5 #54
Comments
/cc @puzrin this is rush! |
Problem is in this line change 8ca0b5b#diff-f4f9b75e4799aa5566d488b8f480de40L37 Change looks correct, but i don't see any broken tests on revert. /cc @rlidwka , take a look please. I don't see check for |
https://github.com/markdown-it/markdown-it/blob/master/lib/parser_block.js#L18
@fengmk2 if you can't wait at all - remove nested array from that line. Will publish fix a bit later, when @rlidwka appears online. |
Fixed in refs branch. It was an optimization attempt gone south. If we have a long list of references (like 533b5c8), this parser would call Anyway, the immediate solution would be to remove references from there. And we have a benchmark that performs 3x times slower than CommonMark (in theory, their parser is linear on that input, and ours isn't), but it might be left for future discussions. |
I use 3.0.4 right now. |
Fixed in published 3.0.6 |
Parse blew markdown,
3.0.5
use0m20.459s
, and3.0.4
use0m2.981s
repeat codes:
The text was updated successfully, but these errors were encountered: