Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probably false detection of "MD007 Unordered list indentation" #313

Open
N0rbert opened this issue Apr 8, 2020 · 9 comments
Open

Probably false detection of "MD007 Unordered list indentation" #313

N0rbert opened this issue Apr 8, 2020 · 9 comments
Labels
bug Something isn't working

Comments

@N0rbert
Copy link

N0rbert commented Apr 8, 2020

Replication Case

Let's assume that we have code presented below:

# First header

Some text before list:

* orange;
* yellow.

Some steps:

1. List of colors:

    * Red
    * Green
    * Yellow

1. Third line

it renders normally here on GitHub and at least in ReText, MarkText, GhostWriter and RStudio.

Environment

Ubuntu 16.04 LTS was used with

MDL Version
0.9.0 as Snap

Expected Behavior

mdl does not show violation of any rules.

Actual Behavior

mdl shows the following:

lists.md:12: MD007 Unordered list indentation

Line 12 is * Red here.
It is nested inside numbered list item.
It does not have any connection with * orange or * yellow.
So I think it is a false detection.

@N0rbert N0rbert added the bug Something isn't working label Apr 8, 2020
@yawboateng
Copy link

yawboateng commented Apr 23, 2020

am having the same issue. Even though the error is on the nested list of line 12 (* Red), i notice if i change the unordered list * orange and * yellow to ordered list 1. orange and 2. yellow, it works fine and passes

Fails on the indented list on * Red, with error message MD007 Unordered list indentation:

# First header

Some text before list:

* orange;
* yellow.

Some steps:

1. List of colors:

    * Red
    * Green
    * Yellow

2. Third line

Works fine:

# First header

Some text before list:

1. orange;
2. yellow.

Some steps:

1. List of colors:

    * Red
    * Green
    * Yellow

2. Third line

@N0rbert
Copy link
Author

N0rbert commented Apr 23, 2020

Above is a silly minimal reproducible example, the real content of my document was different. I do not plan to change writing style to satisfy the linter, even if linter is good overall :)

@yawboateng
Copy link

yawboateng commented Apr 23, 2020

Above is a silly minimal reproducible example, the real content of my document was different. I do not plan to change writing style to satisfy the linter, even if linter is good overall :)

i know! My content is different as well, however similar structure as the example you posted and same error.
I'm not asking you to change your writing style to satisfy the linter 😑.... i'm just reiterating that I also hit the bug and my work around for it - might help the devs debug and fix it :)

ssmall added a commit to GoogleCloudPlatform/cloud-run-anthos-reference-web-app that referenced this issue May 13, 2020
ssmall added a commit to GoogleCloudPlatform/cloud-run-anthos-reference-web-app that referenced this issue May 14, 2020
ssmall added a commit to GoogleCloudPlatform/cloud-run-anthos-reference-web-app that referenced this issue May 14, 2020
@amartin3225
Copy link

Any updates on this? I'm also experiencing this bug

@jaymzh
Copy link
Member

jaymzh commented Sep 28, 2020

Nope, sorry, I have been slammed at work and haven't had time to work on this.

@amartin3225
Copy link

No problem, thanks for the update!

@N0rbert
Copy link
Author

N0rbert commented Jan 17, 2021

Still happens with document from the first comment.

@N0rbert
Copy link
Author

N0rbert commented Aug 8, 2023

cat <<EOF > test.md
# First header

Some text before list:

* orange;
* yellow.

Some steps:

1. List of colors:

    * Red
    * Green
    * Yellow

1. Third line
EOF

mdl 0.12 is still affected by this bug:

$ mdl test.md 
test.md:12: MD007 Unordered list indentation

A detailed description of the rules is available at https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md
$ mdl --version
0.12.0

While remark shows no problems with above file:

$ remark --no-stdout test.md 
test.md: no issues found

$ remark --version
remark: 14.0.2, remark-cli: 11.0.0

Please fix this issue in the master branch of mdl.

@jaymzh
Copy link
Member

jaymzh commented Aug 8, 2023

The issue is still open. What made you believe it is fixed?

I haven't had much time to work on this project but I have been reviewing PRs as they come in. If you want to submit one I'll be happy to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants